[instance] Provide non-vararg arity for update-original-and-current #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 83.23% 83.20% -0.04%
==========================================
Files 37 37
Lines 2511 2524 +13
Branches 215 214 -1
==========================================
+ Hits 2090 2100 +10
- Misses 206 210 +4
+ Partials 215 214 -1 ☔ View full report in Codecov by Sentry. |
camsaul
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
toucan2.instance/update-original-and-currentappears to be frequently invoked insidetoucan2.tools.transformed/apply-result-row-transform. The call chain involves passingargswithapplyin multiple functions, which generates redundant garbage (redundant becauseapply-result-row-transformdoesn't pass anyargs, justf).The PR adds an explicit f-only arity to functions in the call chain.